Dear IIO-ML, Hi Jonathan! On Sun, Dec 8, 2024 at 2:35 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > > On Thu, 5 Dec 2024 17:13:36 +0000 > Lothar Rubusch <l.rubusch@xxxxxxxxx> wrote: > > > Make measurements right-justified, since it is the default for the > > driver and sensor. By not setting the ADXL345_DATA_FORMAT_JUSTIFY bit, > > the data becomes right-judstified. This was the original setting, there > > is no reason to change it to left-justified, where right-justified > > simplifies working on the registers. > > > > Signed-off-by: Lothar Rubusch <l.rubusch@xxxxxxxxx> > > I'm still confused by this one. Does this change affect the data output > to userspace? If seems like it definitely should. If it does we have > an ABI regression somewhere. Is it currently broken and wasn't at some > earlier stage, or is this the patch breaking things? No, it should not affect the userspace. This setting opens the mask for regmap/update bits to allow for changing the data format. My point is rather, does it actually makes sense to allow to change the data format, since the driver will use just one format. The bit was never applied, it's just the mask here. May I ask you, if you could also could give me a brief feedback to the three questions in the cover letter to this series? I would really appreciate, since I'm still unsure if I actually verified everything correctly.
