On Wed, Dec 04, 2024 at 11:20:20AM +0800, Yu-Hsian Yang wrote: > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> 於 2024年12月3日 週二 下午9:50寫道： > > On Tue, Dec 03, 2024 at 05:15:40PM +0800, Eason Yang wrote: ... > > Second, why do you need two regmaps? How debugfs is supposed to work on the > > registers that are 16-bit if you access them via 8-bit regmap and vice versa? > > > > Can't you simply use bulk reads/writes when it makes sense and drop 16-bit > > regmap completely? > > Read VIN info can use word read or byte read, and other registers > should use byte read. > > For a reviewer's comment, If the i2c controller allows word read then the > right thing is to always use it. But how does this differ to bulk read of two sequential 8-bit offsets? And if there is a difference, shouldn't this be addressed on regmap level for all? Like testing for the supported flags and access registers based on the controller capability and user request. -- With Best Regards, Andy Shevchenko
