On Mon, 25 Nov 2024 22:16:15 +0100 Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> wrote: > The 'scan' local struct is used to push data to user space from a > triggered buffer, but it does not set values for inactive channels, as > it only uses iio_for_each_active_channel() to assign new values. > > Initialize the struct to zero before using it to avoid pushing > uninitialized information to userspace. > > Cc: stable@xxxxxxxxxxxxxxx > Fixes: eab35358aae7 ("iio: light: ROHM BH1745 colour sensor") > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> Applied. > --- > drivers/iio/light/bh1745.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iio/light/bh1745.c b/drivers/iio/light/bh1745.c > index 23e9f16090cc..2ffc839c7501 100644 > --- a/drivers/iio/light/bh1745.c > +++ b/drivers/iio/light/bh1745.c > @@ -746,6 +746,8 @@ static irqreturn_t bh1745_trigger_handler(int interrupt, void *p) > int i; > int j = 0; > > + memset(&scan, 0, sizeof(scan)); > + > iio_for_each_active_channel(indio_dev, i) { > ret = regmap_bulk_read(data->regmap, BH1745_RED_LSB + 2 * i, > &value, 2); >