On 11/26/24 15:15, Krzysztof Kozlowski wrote: > On 26/11/2024 15:00, Per-Daniel Olsson wrote: >> This patch series adds support for Texas Instruments OPT4060 RGBW Color sensor >> using the i2c interface. >> >> The driver exposes raw adc values for red, green, blue and clear. The >> illuminance is exposed as a calculated value in lux, the calculation uses the >> wide spectrum green channel as base. The driver supports scaled values for red, >> green and blue. The raw values are scaled so that for a particular test light >> source, typically white, the measurement intensity is the same across the >> different color channels. Integration time can be configured through sysfs as >> well. The OPT4060 sensor supports both rising and falling threshold interrupts. >> These interrupts are exposed as IIO events. The driver also implements an IIO >> triggered buffer with a trigger for conversion ready interrupts. >> >> Changes in v7: >> - Calculation for scaled values changed to remove normalization. >> - Fixed alignment in opt4060_write_ev_period(...). >> - Fixed alignment in opt4060_read_ev_period(...). >> - Updates state to bool in opt4060_write_event_config(...). >> - dt-bindings: Define vdd-supply as required. >> - dt-bindings: Removed description of vdd-supply. >> - dt-bindings: Removed "Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>" >> due to changes. > This is a bug surprise. Because you dropped description of vdd-supply? > No, that's not a reason to request a re-review. I'm sorry for my misstep and for adding to your workload. I wasn't sure what to do in this case with late review comments and clearly picked the wrong path. Won't happen again. Best regards / Per-Daniel > > Please read submitting patches document. > > Keep the tag. I really do not expect more changes to the binding at > point of v6 or v7, especially ones so serious that result in dropping tags. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Best regards, > Krzysztof
