On 25/11/2024 14:35, Robert Budai wrote: > Document the ADIS16550 device devicetree bindings. > > Co-developed-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx> > Signed-off-by: Ramona Gradinariu <ramona.gradinariu@xxxxxxxxxx> > Signed-off-by: Robert Budai <robert.budai@xxxxxxxxxx> > --- > > v2: > - signed of by submitter > > .../bindings/iio/imu/adi,adis16550.yaml | 97 +++++++++++++++++++ > MAINTAINERS | 9 ++ > 2 files changed, 106 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/imu/adi,adis16550.yaml > > diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16550.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16550.yaml > new file mode 100644 > index 000000000000..767b500afbaa > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16550.yaml > @@ -0,0 +1,97 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/imu/adi,adis16550.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices ADIS16550 and similar IMUs > + > +maintainers: > + - Nuno Sa <nuno.sa@xxxxxxxxxx> > + - Ramona Gradinariu <ramona.gradinariu@xxxxxxxxxx> > + - Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx> > + > +properties: > + compatible: > + enum: > + - adi,adis16550 > + - adi,adis16550w What is the difference between them? You have description and commit msg for this. > + > + reg: > + maxItems: 1 > + > + spi-cpha: true > + > + spi-cpol: true > + > + spi-max-frequency: > + maximum: 15000000 > + > + vdd-supply: true > + > + interrupts: > + maxItems: 1 > + > + reset-gpios: > + description: > + Must be the device tree identifier of the RESET pin. If specified, Do not describe DT syntax. s/Must be the device tree identifier of the// Instead something like "RESET active low pin". > + it will be asserted during driver probe. As the line is active low, > + it should be marked GPIO_ACTIVE_LOW. This is false. It should not. Instead, it should be marked according to the board design. You can have there inverter. > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + description: If not provided, then the internal clock is used. > + > + adi,sync-mode: > + $ref: /schemas/types.yaml#/definitions/string Do not redefine properties. You are stuck with what is there already :/ > + description: | > + Configures the device SYNC pin. > + scaled_sync: Device handles internally custom scaled > + sync mode. It is stored in a designated register. > + enum: > + - direct_sync > + - scaled_sync > + > +required: > + - compatible > + - reg > + - interrupts > + - spi-cpha > + - spi-cpol > + - spi-max-frequency > + - vdd-supply > + > +allOf: > + - if: > + properties: > + adi,sync-mode: > + enum: [direct_sync, scaled_sync] This does not make sense. There is no other option in this enum. Not sure what you wanted to achieve here. If dependency on property then required, see example-schema. > + > + then: > + dependencies: > + adi,sync-mode: [ clocks ] > + > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +additionalProperties: false unevaluatedProperties false Best regards, Krzysztof
