On 20/11/2024 21:26, Mikael Gonella-Bolduc wrote: >>>> +$id: http://devicetree.org/schemas/iio/light/avago,apds9160.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Broadcom Combined Proximity & Ambient light sensor >>>> + >>>> +maintainers: >>>> + - Mikael Gonella-Bolduc <m.gonella.bolduc@xxxxxxxxx> >>>> + >>>> +description: | >>>> + Datasheet: https://docs.broadcom.com/docs/APDS-9160-003-DS >>>> + >>>> +properties: >>>> + compatible: >>>> + enum: >>>> + - avago,apds9160 >>>> + - broadmobi,apds9160 >>> >>> What is the difference between these two devices? There's no match data, >>> makes it seem like there should be a fallback going on here. >> Same device names suggest this is some legacy. We don't take new >> bindings for legacy stuff. >> >> Best regards, >> Krzysztof > > Hi, > Thank you for the feedback. > > There's no difference between these two devices, it's the same chip using two different names. > There's two names because the chip was first released before the Avago & Broadcom acquisition. > > The datasheet available has the avago name in it and it's referenced using both names. > I did not know which name to include so I wrote both. Choose only one. Preferably newer one. Just notice that broadcom and broadmobi are a bit different entities, according to vendor prefixes. > > It's old but still being produced today and active for new designs. > > Is it too old for the driver to be mainlined? No, it is fine. > If not, which name should I use? Best regards, Krzysztof
