On Mon, Nov 18, 2024 at 01:43:02PM +0000, Sperling, Tobias wrote: > > On Wed, Nov 13, 2024 at 02:41:08PM +0000, Sperling, Tobias wrote: > > > >From 6a06973e1023ca6a128c8d426b4c87887117c084 Mon Sep 17 00:00:00 > > 2001 > > > From: Tobias Sperling <tobias.sperling@xxxxxxxxxxx> > > > Date: Wed, 13 Nov 2024 14:52:49 +0100 > > > Subject: [PATCH 1/2] dt-bindings: iio: adc: Introduce ADS7138 > > > > Your patch is corrupted. > > Yeah, might look a little different from what you are usually used to see, as > I had to copy the patch manually to the mails body. SMTP doesn't work > for us unfortunately. Anyway, the patch applies just fine with "git apply", > doesn't it for you? git-apply doesn't apply the commit message. git-am is what you want. It tripped up my scripts, but that seems to because it has line-feed char in Message-ID. It did apply manually running b4. There's a b4 relay you can use to send if you can't get SMTP to work. Messing with things manually is asking for trouble. > > > Add documentation for the driver of ADS7128 and ADS7138 12-bit, 8-channel > > > analog-to-digital converters. These ADCs have a wide operating range and > > > a wide feature set. Communication is based on the I2C interface. > > > > > > Signed-off-by: Tobias Sperling <tobias.sperling@xxxxxxxxxxx> > > > --- > > > .../bindings/iio/adc/ti,ads7138.yaml | 60 +++++++++++++++++++ > > > 1 file changed, 60 insertions(+) > > > create mode 100644 > > Documentation/devicetree/bindings/iio/adc/ti,ads7138.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads7138.yaml > > b/Documentation/devicetree/bindings/iio/adc/ti,ads7138.yaml > > > new file mode 100644 > > > index 000000000000..c70ad5747828 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads7138.yaml > > > @@ -0,0 +1,60 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: > > http://devicetree/. > > org%2Fschemas%2Fiio%2Fadc%2Fti%2Cads7138.yaml%23&data=05%7C02%7C% > > 7Cf943e3cd23dd4c28422608dd059c1cd9%7Cfe3606fad3974238999768dcd7851f > > 64%7C1%7C0%7C638672890241515102%7CUnknown%7CTWFpbGZsb3d8eyJFb > > XB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpb > > CIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=KFK6uoMuDUTlwSRv5jUd%2FQ > > mBqKRHIDCq%2Bb1nWhOkZTk%3D&reserved=0 > > > +$schema: > > http://devicetree/. > > org%2Fmeta- > > schemas%2Fcore.yaml%23&data=05%7C02%7C%7Cf943e3cd23dd4c28422608d > > d059c1cd9%7Cfe3606fad3974238999768dcd7851f64%7C1%7C0%7C638672890 > > 241534499%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOi > > IwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0% > > 7C%7C%7C&sdata=2Dj6PlC%2BzKkjcxWosWYMd9Wnh71dKJZfXx5af85vQf8%3D > > &reserved=0 > > > + > > > +title: Texas Instruments ADS7128/ADS7138 Analog to Digital Converter (ADC) > > > + > > > +maintainers: > > > + - Tobias Sperling <tobias.sperling@xxxxxxxxxxx> > > > + > > > +description: | > > > + The ADS7128 is 12-Bit, 8-Channel Sampling Analog to Digital Converter (ADC) > > > + with an I2C interface. > > > + > > > + Datasheets: > > > + > > https://www.ti.co/ > > m%2Fproduct%2FADS7128&data=05%7C02%7C%7Cf943e3cd23dd4c28422608d > > d059c1cd9%7Cfe3606fad3974238999768dcd7851f64%7C1%7C0%7C638672890 > > 241551566%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOi > > IwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0% > > 7C%7C%7C&sdata=MtZjBaLGanD7%2BwQJZDc54CWVVkDbUV1jAv9PixBdOxk%3 > > D&reserved=0 > > > + > > https://www.ti.co/ > > m%2Fproduct%2FADS7138&data=05%7C02%7C%7Cf943e3cd23dd4c28422608d > > d059c1cd9%7Cfe3606fad3974238999768dcd7851f64%7C1%7C0%7C638672890 > > 241564942%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOi > > IwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0% > > 7C%7C%7C&sdata=DlLY9HTzdOyvooQA%2FCI%2BQJu0REGlwP2mpR%2Bp6M8C > > 5yk%3D&reserved=0 > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - ti,ads7128 > > > + - ti,ads7138 > > > > What's the difference between the 2? > > The 7128 has some more hardware features like a root-mean-square > module and a zero-crossing-detect module. Base functionality and > therefore, what's implemented in the driver yet, is the same, however. Please put that in the description. Rob
