On 07/11/2024 14:45, Darius Berghe wrote: > Add the adis16486, adis16487 and adis16489 Six Degrees > of Freedom Inertial Sensors to the list of compatible devices > of the adis16480 iio subsystem driver. > > adis16486 is similar to adis16485, has the exact same channels > but acceleration and delta velocity scales are different. > > adis16487 is fallback compatible with adis16485. This was never tested - visible easily from the diff. No need to ask reviewers to do the tools job. Tools are for that. <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. </form letter> Best regards, Krzysztof
