On Sat, Nov 02, 2024 at 03:50:43PM -0400, Aren Moynihan wrote: > If the chip isn't powered, this call is likely to return an error. > Without a log here the driver will silently fail to probe. Potential > errors include ENXIO (when the chip isn't powered) and ETIMEDOUT (when > the i2c bus isn't powered). > > This function is only called from stk3310_probe, and this condition > should return an error, which fits what dev_err_probe is designed for. ... > + return dev_err_probe(dev, ret, "failed to read chip id\n"); Please, make sure you have consistent style in the messages. Most of what I have seen use period at the end. This one doesn't. -- With Best Regards, Andy Shevchenko
