On Sat, Nov 02, 2024 at 03:50:39PM -0400, Aren Moynihan wrote: > The vdd and leda supplies must be powered on for the chip to function > and can be powered off during system suspend. > > This was originally based on a patch by Ondrej Jirman[1], but has been > rewritten since. > > 1: https://codeberg.org/megi/linux/commit/a933aff8b7a0e6e3c9cf1d832dcba07022bbfa82 Make it a Link tag... > ...here Link: https://codeberg.org/megi/linux/commit/a933aff8b7a0e6e3c9cf1d832dcba07022bbfa82 [1] > Signed-off-by: Aren Moynihan <aren@xxxxxxxxxxxxxxxxx> ... > + ret = devm_regulator_bulk_get(&client->dev, ARRAY_SIZE(data->supplies), > + data->supplies); > + if (ret) > + return dev_err_probe(&client->dev, ret, "get regulators failed\n"); With previously introduced temporary 'dev' variable these become: ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(data->supplies), data->supplies); if (ret) return dev_err_probe(dev, ret, "get regulators failed\n"); ... > + ret = stk3310_regulators_enable(data); > + if (ret) > + return dev_err_probe(&client->dev, ret, > + "regulator enable failed\n"); > + > + ret = devm_add_action_or_reset(&client->dev, stk3310_regulators_disable, data); > + if (ret) > + return dev_err_probe(&client->dev, ret, > + "failed to register regulator cleanup\n"); So do these... ... > + ret = regulator_bulk_disable(ARRAY_SIZE(data->supplies), data->supplies); Is array_size.h included? > + if (ret) { > + dev_err(dev, "failed to disable regulators: %d\n", ret); > + return ret; > + } ... > - u8 state = 0; > + int ret; > struct stk3310_data *data; > + u8 state = 0; Can we try to make it RCT ordered? -- With Best Regards, Andy Shevchenko
