On 11/3/24 2:20 PM, Uwe Kleine-König wrote: > On Sun, Nov 03, 2024 at 03:00:14PM +0100, Uwe Kleine-König wrote: >> Hello David, >> >> On Sat, Nov 02, 2024 at 01:50:35AM +0800, kernel test robot wrote: >>> kernel test robot noticed the following build errors: >>> >>> [auto build test ERROR on 6fb2fa9805c501d9ade047fc511961f3273cdcb5] >>> >>> url: https://github.com/intel-lab-lkp/linux/commits/David-Lechner/pwm-core-export-pwm_get_state_hw/20241030-052134 >>> base: 6fb2fa9805c501d9ade047fc511961f3273cdcb5 >>> patch link: https://lore.kernel.org/r/20241029-pwm-export-pwm_get_state_hw-v2-2-03ba063a3230%40baylibre.com >>> patch subject: [PATCH v2 2/2] iio: adc: ad7606: finish pwm_get_state_hw() TODO >>> config: i386-randconfig-141-20241101 (https://download.01.org/0day-ci/archive/20241102/202411020101.5Hs6MkwQ-lkp@xxxxxxxxx/config) >>> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 >>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241102/202411020101.5Hs6MkwQ-lkp@xxxxxxxxx/reproduce) >>> >>> If you fix the issue in a separate patch/commit (i.e. not just a new version of >>> the same patch/commit), kindly add following tags >>> | Reported-by: kernel test robot <lkp@xxxxxxxxx> >>> | Closes: https://lore.kernel.org/oe-kbuild-all/202411020101.5Hs6MkwQ-lkp@xxxxxxxxx/ >>> >>> All errors (new ones prefixed by >>): >>> >>> drivers/iio/adc/ad7606.c: In function 'ad7606_read_raw': >>>>> drivers/iio/adc/ad7606.c:765:23: error: implicit declaration of function 'pwm_get_state_hw'; did you mean 'pwm_get_state'? [-Werror=implicit-function-declaration] >>> 765 | ret = pwm_get_state_hw(st->cnvst_pwm, &cnvst_pwm_state); >>> | ^~~~~~~~~~~~~~~~ >>> | pwm_get_state >>> cc1: some warnings being treated as errors >> >> The problem here is that there is no declaration (and implementation) of >> pwm_get_state_hw() with CONFIG_PWM=n. Does it make sense to enable the >> ad7606 driver without enabling PWM support? If yes, we should add a >> dummy implementation of pwm_get_state_hw(), if not, a depends on PWM >> should be introduced. > > Looking at the driver, the PWM is optional. So I rewrote the commit from > patch 1/2 in this series and added a dummy. > > Best regards > Uwe Thanks!
