On Sun, Nov 03, 2024 at 11:31:03AM +0000, Jonathan Cameron wrote: > On Sat, 2 Nov 2024 15:50:39 -0400 > Aren Moynihan <aren@xxxxxxxxxxxxxxxxx> wrote: > > > The vdd and leda supplies must be powered on for the chip to function > > and can be powered off during system suspend. > > > > This was originally based on a patch by Ondrej Jirman[1], but has been > > rewritten since. > > > > 1: https://codeberg.org/megi/linux/commit/a933aff8b7a0e6e3c9cf1d832dcba07022bbfa82 > > > > Signed-off-by: Aren Moynihan <aren@xxxxxxxxxxxxxxxxx> > > --- > > > > Notes: > > Changes in v4: > > - fix variable declaration order in stk3310_resume to match the rest of > > the driver > > For this Andy was asking for consistency. Generally we don't insist on a > particular ordering in IIO drivers, but we do prefer them to be the same. > Your new ordering is inconsistent between resume and suspend. Whilst > existing code may be inconsistent, you can still pick most common ordering > and use that for your new code. > > If the existing driver is inconsistent then feel free to tidy that up but > do it in a precursor patch so there is a consistent style for you to then > carry on. Oh right, the order of declarations in stk3310_suspend also needs to be flipped. Is that simple enough that you can fix it when applying this? Apparently I was being dense, I checked the rest of the driver to see what it did (it's consistent about putting shorter lines & ones without an assignment first), and fixed the case Andy pointed out to match that, but failed to check the rest of the patch. Thanks - Aren
