On Sat, 2 Nov 2024 21:48:04 +0200 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > Thu, Oct 31, 2024 at 08:52:05AM +0200, victor.duicu@xxxxxxxxxxxxx kirjoitti: > > From: Victor Duicu <victor.duicu@xxxxxxxxxxxxx> > > > > This patch implements ACPI support to Microchip pac1921. > > The driver can read shunt resistor value and label from ACPI table. > > This ID might be okay, but can we please have: > 1) the list of the models (or a model) of the device on the market that has this; > 2) ACPI DSDT excerpt of the respective Device object? > > (I mean a laptop, tablet, phone or other device that has this sensor described > in the ACPI) For a valid ID used in a patch submitted by an employee of the relevant company this is a steep ask. As far as I'm concerned it is definitely not a requirement (unlike for non compliant IDs!) There is no reason why a device might be public at this time. For a good upstream first company almost all IDs go into the kernel 'before' device announcement or sales. I very much want to encourage that not put potential barriers in the way. So Victor, if you can provide the info Andy requested, then great but if not feel free to say so. (+ the snippet is useful anyway and is unlikely to contain anything confidential.) Jonathan
