On Fri, 1 Nov 2024 11:52:01 +0200
Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx> wrote:
> The adxl380_read_chn function returns either a negative value in case an
> error occurs or the actual sample.
>
> Check only for negative values after a channel is read.
>
> Fixes: df36de13677a ("iio: accel: add ADXL380 driver")
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>
ouch. Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
> ---
> drivers/iio/accel/adxl380.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/adxl380.c b/drivers/iio/accel/adxl380.c
> index f80527d899be..b19ee37df7f1 100644
> --- a/drivers/iio/accel/adxl380.c
> +++ b/drivers/iio/accel/adxl380.c
> @@ -1181,7 +1181,7 @@ static int adxl380_read_raw(struct iio_dev *indio_dev,
>
> ret = adxl380_read_chn(st, chan->address);
> iio_device_release_direct_mode(indio_dev);
> - if (ret)
> + if (ret < 0)
> return ret;
>
> *val = sign_extend32(ret >> chan->scan_type.shift,
