On Thu, Oct 31, 2024 at 07:17:17PM +0000, Jonathan Cameron wrote: > On Wed, 30 Oct 2024 18:02:17 +0200 > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > Fill data with NULL, if provided, when returning NULL from > > iio_get_acpi_device_name_and_data(). Note, the current users check > > for name to be valid, except one case which was initially doing > > like that and has to be fixed separately. > > > > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > Closes: https://lore.kernel.org/r/54fac4a7-b601-40ce-8c00-d94807f5e214@stanley.mountain > > Fixes: dc60de4eb0a4 ("iio: acpi: Add iio_get_acpi_device_name_and_data() helper function") > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > This is counter intuitive as usual expectation would be no side effects on an > error return. How hard to fix all the users to initialize to NULL if they > care about that? v2 just has been sent, indeed the result looks much better, thanks for the review! > There is still a chance we set it to NULL in here anyway, but that should only happen > if we know the return is good in the sense of no error (missing ACPI etc) > but not necessarily that dev_name() won't return NULL. > > Don't think dev_name() can currently return NULL but 'maybe' it could... dev_name() can't return NULL on the properly initialised device (either with device_add(), or via dev_set_name() call). I do not think we can ever get to the ->probe() without the above. Tell me, if I'm wrong. -- With Best Regards, Andy Shevchenko
