On Mon, Oct 28, 2024 at 11:29:35AM -0400, Aren wrote:
> On Mon, Oct 28, 2024 at 04:45:35PM +0200, Andy Shevchenko wrote:
> > On Mon, Oct 28, 2024 at 10:19:59AM -0400, Aren Moynihan wrote:
> > > If the chip isn't powered, this call is likely to return an error.
> > > Without a log here the driver will silently fail to probe. Common errors
> > > are ENXIO (when the chip isn't powered) and ETIMEDOUT (when the i2c bus
> > > isn't powered).
> >
> > The commit message does not explain why dev_err_probe() has been chosen
> > and not simple dev_err().
>
> This function is only called from stk3310_probe, and this condition
> should propagate it's error, so it fits what dev_err_probe is designed
> for. dev_err would be pretty much equivalent just longer, like this:
>
> if (ret < 0) {
> dev_err(&client->dev, "failed to read chip it: %d\n", ret);
> return ret;
> }
It's fine, the problem is the commit message in the patch. Please,
update the commit message accordingly.
--
With Best Regards,
Andy Shevchenko
