On Thu, 24 Oct 2024 10:16:58 +0200
Julien Stephan <jstephan@xxxxxxxxxxxx> wrote:
> adaq4370-4 (2MSPS) and adaq4380-4 (4MSPS) are quad-channel precision data
> acquisition signal chain μModule solutions compatible with the ad738x
> family, with the following differences:
>
> - pin selectable gain in front of each 4 adc
> - internal reference is 3V derived from refin-supply (5V)
> - additional supplies
>
> This implies that IIO_CHAN_INFO_SCALE can not be shared by type.
If respinning for other reasons, maybe
"by type for these new devices." or I can tweak whilst applying.
>
> Signed-off-by: Julien Stephan <jstephan@xxxxxxxxxxxx>
Looks good to me. Only comment is a 'maybe' for pulling out a local
dev variable to shave a few characters off some long lines.
May not be worth the effort.
> @@ -1104,6 +1186,42 @@ static int ad7380_probe(struct spi_device *spi)
> st->vcm_mv[i] = ret / 1000;
> }
>
> + for (i = 0; i < MAX_NUM_CHANNELS; i++)
> + st->gain_milli[i] = AD7380_DEFAULT_GAIN_MILLI;
> +
> + if (st->chip_info->has_hardware_gain) {
> + device_for_each_child_node_scoped(&spi->dev, node) {
> + unsigned int channel, gain;
> + int gain_idx;
> +
> + ret = fwnode_property_read_u32(node, "reg", &channel);
> + if (ret)
> + return dev_err_probe(&spi->dev, ret,
Hmm. It might be worth a precursor patch to add
struct device *dev = &spi->dev; for probe to shorten all these a little
(+ a bunch of existing cases)
Up to you though.
> + "Failed to read reg property\n");
> +
> + if (channel >= st->chip_info->num_channels - 1)
> + return dev_err_probe(&spi->dev, -EINVAL,
> + "Invalid channel number %i\n",
> + channel);
> +
> + ret = fwnode_property_read_u32(node, "adi,gain-milli",
> + &gain);
> + if (ret && ret != -EINVAL)
> + return dev_err_probe(&spi->dev, ret,
> + "Failed to read gain for channel %i\n",
> + channel);
> + if (ret != -EINVAL) {
> + /*
> + * Match gain value from dt to one of supported
> + * gains
> + */
> + gain_idx = find_closest(gain, ad7380_gains,
> + ARRAY_SIZE(ad7380_gains));
> + st->gain_milli[channel] = ad7380_gains[gain_idx];
> + }
> + }
> + }
> +
