On 10/19/24 8:49 AM, Jonathan Cameron wrote: > On Fri, 18 Oct 2024 13:42:10 +0300 > Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx> wrote: > >> Add support for the AD485X a fully buffered, 8-channel simultaneous >> sampling, 16/20-bit, 1 MSPS data acquisition system (DAS) with >> differential, wide common-mode range inputs. >> >> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx> > > A few minor things from me that I could fix whilst applying, > but David gave a much more detailed review of v3, so I'll wait > for his feedback on this. I haven't dug into datasheets much and > may well have missed other things. > Many of my review comments were not addressed at all. :-( Plus one addressed incorrectly (rounding PWM period down instead of the suggested rounding up). I still have major concerns about userspace-facing things like the questionable use of the offset attribute and fixing how oversampling interacts with the scan_type.
