On Sun, 20 Oct 2024 12:56:12 +0100 Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > On Mon, 14 Oct 2024 17:32:00 +0300 > Ramona Alexandra Nechita <ramona.nechita@xxxxxxxxxx> wrote: > > > Add support for AD7770, AD7771, AD7779 ADCs. The device is capable of > > sending out data both on DOUT lines interface,as on the SDO line. > > The driver currently implements only the SDO data streaming mode. SPI > > communication is used alternatively for accessing registers and streaming > > data. Register accesses are protected by crc8. > > > > Signed-off-by: Ramona Alexandra Nechita <ramona.nechita@xxxxxxxxxx> > > A few comments inline. I also tweaked white space in a few places > whilst applying. Target in IIO is still sub 80 chars whenever it > doesn't hurt readability. > > Also, you had unusual formatting for some of the macros. Avoid mixing > tabs then spaces for indentation of the \ > > series applied to the togreg branch of iio.git and initially pushed > out as testing so 0-day can take a look. > > One missing return in the debugfs register access as well. Please > check I fixed that up correctly. Seems I missed the cancel button when I noticed the build message just as the other email went out. Sorry for the noise! > > Thanks, > > Jonathan
