On Fri, 18 Oct 2024 11:02:41 +0000 bugzilla-daemon@xxxxxxxxxx wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=219192 > > --- Comment #9 from Andy Shevchenko (andy.shevchenko@xxxxxxxxx) --- > This > https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-6.13/core&id=b2b8a75e1d88c551a0b30d44d0be552210219eea > one is related and may be used as an example how to fix that. > Maybe. Though not quite the same as in this case the code really is unreachable. The compiler is simply failing to discover it. We could but BUG() in all these places but that is nasty. The series: https://lore.kernel.org/all/20241001-cleanup-if_not_cond_guard-v1-0-7753810b0f7a@xxxxxxxxxxxx/ gives code the compiler should never fail to figure out, so using that instead is a better approach in my opinion and Peter Z just applied the infrastructure to his tree today. Jonathan
