On Thu, 03 Oct 2024 23:04:50 +0200 Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> wrote: > This driver makes use of triggered buffers, but does not select the > required modules. > > Fixes: 2a86487786b5 ("iio: adc: ti-ads8688: add trigger and buffer support") > Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'. Fixes tag must be part of the tag block. Also this one looks to be a false positive. The driver includes buffer.h but doesn't actually have buffered support. > > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> > --- > drivers/iio/adc/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index 45872a4e2acf..e6be1f1ec79f 100644 > --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -1483,6 +1483,8 @@ config TI_ADS8344 > config TI_ADS8688 > tristate "Texas Instruments ADS8688" > depends on SPI > + select IIO_BUFFER > + select IIO_TRIGGERED_BUFFER > help > If you say yes here you get support for Texas Instruments ADS8684 and > and ADS8688 ADC chips >