On Sat, 2024-09-28 at 17:42 +0100, Jonathan Cameron wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> On Wed, 25 Sep 2024 18:08:56 +0300
> <victor.duicu@xxxxxxxxxxxxx> wrote:
>
> > From: Victor Duicu <victor.duicu@xxxxxxxxxxxxx>
> >
> >
> > MODULE_DEVICE_TABLE(of, pac1921_of_match);
> >
> > +static const struct acpi_device_id pac1921_acpi_match[] = {
> > + { "MCHP1921" },
>
> That's a valid ID for once which is good. I'll assume Microchip
> has a process for tracking these and avoiding clashes.
>
MCHP id is registered with UEFI and MCHP1921 is tracked internally.
> > + { }
> > +};
> > +MODULE_DEVICE_TABLE(acpi, pac1921_acpi_match);
> > static struct i2c_driver pac1921_driver = {
> > .driver = {
> > .name = "pac1921",
> > .pm = pm_sleep_ptr(&pac1921_pm_ops),
> > .of_match_table = pac1921_of_match,
> > + .acpi_match_table = pac1921_acpi_match
> > },
> > .probe = pac1921_probe,
> > .id_table = pac1921_id,
> >
> > base-commit: fec496684388685647652ab4213454fbabdab099
>
