On Sat, Sep 14, 2024 at 03:45:58PM +0200, Hans de Goede wrote: > On 9/12/24 3:51 PM, Hans de Goede wrote: > > On 9/11/24 11:22 PM, Andy Shevchenko wrote: > On 9/13/24 11:31 AM, Andy Shevchenko wrote: > > Have you grepped over your collection of real DSDTs? > > Yes I did, but I just double-checked looking for only LTER and there > are several DSDTs using LTER0303 for an ambient light sensor. > > duckduckgo-ing for LTER0303 finds: > > https://www.catalog.update.microsoft.com/Search.aspx?q=lter0303 > > which is actually quite an interesting URL to search for ACPI > HID-s used in any Windows drivers. Very good finding! Bookmarked to check any other ACPI ID case with that as well. > Checking for LTER0301: > > https://www.catalog.update.microsoft.com/Search.aspx?q=lter0301 > > Shows that that HID is also actually used, so: > > > Thanks, patch looks good to me: > > > > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > Correction, at least the LTER0301 ACPI id seems to actually be real: > > https://www.catalog.update.microsoft.com/Search.aspx?q=lter0301 > > So NACK for dropping all 3 HIDs. > > It seems to me that the LTER05xx HIDs can be dropped and > a LTER0303 HID should be added instead of dropping all HIDs. I'll update the patch with reference to that catalog. > Note I do not have any hw with a ltr303 light sensor, so > I cannot test this. Neither can I. So, let's drop 'LTER05' and add a comment WRT the 0x01. -- With Best Regards, Andy Shevchenko
