> Hi Abhash, > > A few minor comments inline and an (optional) request to cleanup > the mask definitions in the existing code. > > > > #define LTR390_PART_NUMBER_ID 0xb > > #define LTR390_ALS_UVS_GAIN_MASK 0x07 > > +#define LTR390_ALS_UVS_MEAS_RATE_MASK 0x07 > These masks should be converted to GENMASK(). > If you don't mind doing it a precursor patch to do so > would be nice to have. > Can I do the mask to GENMASK conversion in an additional cleanup patch at the end? The patch would clean up stuff related to newlines and such. Meanwhile I would use GENMASK for the new ones Thanks, Abhash
