Re: [PATCH v3 0/2] Add I2C driver for Bosch BMI270 IMU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alex!

I recently received a review for the code for the BMP280 sensors, and I think
it applies well to you as well. Since you are using the sleeping functions in
your code, maybe a comment on top that explains why this value or where you
found it in the datasheet would be helpful.

Specifically for the Bosch Sensors, because Bosch's datasheets have either
hidden or no information at all, and you need to search for stuff in the
respective C sensor API in the Bosch GitHub.

Cheers,
Vasilis




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux