On 9/5/24 11:28 AM, Rob Herring (Arm) wrote: > > On Thu, 05 Sep 2024 17:17:31 +0200, Angelo Dureghello wrote: >> From: Angelo Dureghello <adureghello@xxxxxxxxxxxx> >> >> There is a version AXI DAC IP block (for FPGAs) that provides >> a physical bus for AD3552R and similar chips. This can be used >> instead of a typical SPI controller to be able to use the chip >> in ways that typical SPI controllers are not capable of. >> >> The binding is modified so that either the device is a SPI >> peripheral or it uses an io-backend. >> >> Signed-off-by: Angelo Dureghello <adureghello@xxxxxxxxxxxx> >> --- >> .../devicetree/bindings/iio/dac/adi,ad3552r.yaml | 42 ++++++++++++++++++++-- >> 1 file changed, 40 insertions(+), 2 deletions(-) >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/iio/dac/adi,ad3552r.example.dtb: /example-1/axi_dac@44a70000: failed to match any schema with compatible: ['adi,axi-dac-ad3552r'] I think this can be fixed by putting commit "dt-bindings: iio: dac: add ad3552r axi-dac compatible" first in the series before commit "dt-bindings: iio: dac: ad3552r: add io-backend property". > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240905-wip-bl-ad3552r-axi-v0-iio-testing-v2-1-87d669674c00@xxxxxxxxxxxx > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >