On Mon, Sep 02, 2024 at 07:19:26PM +0100, Jonathan Cameron wrote:
> On Mon, 2 Sep 2024 14:47:59 +0300
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Sun, Sep 01, 2024 at 02:59:48PM +0100, Jonathan Cameron wrote:
...
> > > - irq_type = irqd_get_trigger_type(irq_get_irq_data(hw->irq));
> > > + irq_type = irq_get_trigger_type(hw->irq);
> >
> > >
> >
> > No blank line?
> Might was well roll it into the switch now you mention it!
I think it's discussable (from the readability perspective), but FWIW, I'm fine
with any of your choices here.
> > > switch (irq_type) {
> > > case IRQF_TRIGGER_HIGH:
--
With Best Regards,
Andy Shevchenko
