On Sun, Sep 01, 2024 at 02:59:39PM +0100, Jonathan Cameron wrote: > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > Use irq_get_trigger_type() to replace getting the irq data then the > type in two steps. ... > - irq_trig = irqd_get_trigger_type(irq_get_irq_data(sdata->irq)); > + irq_trig = irq_get_trigger_type(sdata->irq); Usually I think the /* ...comment on flow... */ foo = bar(); ...something with foo that is commented above... is slightly better as after reading the comment we immediately see where the foo comes from. > /* > * If the IRQ is triggered on falling edge, we need to mark the > * interrupt as active low, if the hardware supports this. But, it's not a big deal. -- With Best Regards, Andy Shevchenko
