On Sun, Sep 01, 2024 at 02:59:37PM +0100, Jonathan Cameron wrote: > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > Use irq_get_trigger_type() to replace getting the irq data then the > type in two steps. ... > - irq_type = irqd_get_trigger_type(irq_get_irq_data(irq)); > + irq_type = irq_get_trigger_type(irq); > While at it, I would drop this blank line as well. Because the next line is quite coupled with the previous one. > switch (irq_type) { -- With Best Regards, Andy Shevchenko