Re: [PATCH v2] iio: imu: inv_mpu6050: Remove duplicate code between labels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

thanks for the patch, but beware that this modification is breaking the code!

You are deleting the normal function path return IRQ_HANDLED (without the goto end_session). With this patch, the reset fifo function code inv_reset_fifo() will be called even if the IRQ handler is functioning correctly.

This is a no go for me, I don't think we can easily change these 2 labels anyway.

Best regards,
JB

________________________________________
From: gyeyoung <gye976@xxxxxxxxx>
Sent: Monday, September 2, 2024 03:53
To: Jonathan Cameron <jic23@xxxxxxxxxx>
Cc: lars@xxxxxxxxxx <lars@xxxxxxxxxx>; Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@xxxxxxx>; linux-iio@xxxxxxxxxxxxxxx <linux-iio@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH v2] iio: imu: inv_mpu6050: Remove duplicate code between labels
 
This Message Is From an Untrusted Sender
You have not previously corresponded with this sender.
 
On Sun, Sep 1, 2024 at 11:11 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
>
> On Sun,  1 Sep 2024 21:08:39 +0900
> Gyeyoung Baek <gye976@xxxxxxxxx> wrote:
>
> > 'flush_fifo' label performs same task as 'endsession' label
> > immediately after calling 'env_reset_fifo' function.
> > So i remove that duplication.
> >
> > Signed-off-by: Gyeyoung Baek <gye976@xxxxxxxxx>
>
> Ok. This doesn't greatly affect readability and the code
> ends up a bit shorter.
>
> Applied
>
> Jonathan
>

Thank you for approving it.

-Gyeyoung




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux