Hello, beware this patch is buggy. It will break the IRQ handler function of inv_mpu6050 driver. The normal code path is going through end_session label without goto, and expect the function return before executing inv_reset_fifo. Without it, the reset FIFO function will be called for every interrupt and is breaking normal functioning of the driver. Best regards, JB ________________________________________ From: Markus Elfring <Markus.Elfring@xxxxxx> Sent: Monday, September 2, 2024 08:00 To: Gyeyoung Baek <gye976@xxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx <linux-iio@xxxxxxxxxxxxxxx>; Jonathan Cameron <jic23@xxxxxxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx> Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx> Subject: Re: iio: imu: inv_mpu6050: Remove duplicate code between labels This Message Is From an Untrusted Sender You have not previously corresponded with this sender. >>> Hello, I apologize for the insufficient explanation. >> >> How will the commit message be improved further? … > Since the code is short, This implementation detail can be nice. > I think it's fine for now. Please reconsider such a view once more. Are imperative wordings also more desirable for a better change description? https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc6*n45__;Iw!!FtrhtPsWDhZ6tw!Hb9yipjKJXmB-DO9gWKADZfQZHI84WEFUc6Ns1iGhpAfvAAyjrnLQRJZLU2Ha0nI8Fs-HBqHFlFbq0Kl-O1CJwYLe776xbRywQ$[git[.]kernel[.]org] Regards, Markus
