Minor stuff inline. I'll fix up whilst applying. Jonathan > diff --git a/drivers/iio/adc/sophgo-cv1800b-adc.c b/drivers/iio/adc/sophgo-cv1800b-adc.c > new file mode 100644 > index 000000000000..f4cdec966694 > --- /dev/null > +++ b/drivers/iio/adc/sophgo-cv1800b-adc.c > @@ -0,0 +1,218 @@ > +static int cv1800b_adc_read_raw(struct iio_dev *indio_dev, > + struct iio_chan_spec const *chan, > + int *val, int *val2, long mask) > +{ > + struct cv1800b_adc *saradc = iio_priv(indio_dev); > + > + switch (mask) { > + case IIO_CHAN_INFO_RAW:{ > + u32 sample; > + > + scoped_guard(mutex, &saradc->lock) { > + int ret; > + > + cv1800b_adc_start_measurement(saradc, chan->scan_index); > + ret = cv1800b_adc_wait(saradc); > + if (ret < 0) > + return ret; > + > + sample = readl(saradc->regs + CV1800B_ADC_CH_RESULT_REG(chan->scan_index)); > + } > + if (!(sample & CV1800B_ADC_CH_VALID)) > + return -ENODATA; > + > + *val = sample & CV1800B_ADC_CH_RESULT; > + return IIO_VAL_INT; > + } > + case IIO_CHAN_INFO_SCALE: > + *val = 3300; > + *val2 = 12; > + return IIO_VAL_FRACTIONAL_LOG2; > + case IIO_CHAN_INFO_SAMP_FREQ: This needs {} as per the build bot. If nothing major comes up, I'll tweak whilst applying. > + u32 status_reg = readl(saradc->regs + CV1800B_ADC_CYC_SET_REG); > + int clk_div = (1 + FIELD_GET(CV1800B_MASK_CLKDIV, status_reg)); > + int freq = clk_get_rate(saradc->clk) / clk_div; > + int nb_startup_cycle = 1 + FIELD_GET(CV1800B_MASK_STARTUP_CYCLE, status_reg); > + int nb_sample_cycle = 1 + FIELD_GET(CV1800B_MASK_SAMPLE_WINDOW, status_reg); > + int nb_compare_cycle = 1 + FIELD_GET(CV1800B_MASK_COMPARE_CYCLE, status_reg); > + > + *val = freq / (nb_startup_cycle + nb_sample_cycle + nb_compare_cycle); > + return IIO_VAL_INT; > + default: > + return -EINVAL; > + } > +} > +static int cv1800b_adc_probe(struct platform_device *pdev) > +{ > + struct cv1800b_adc *saradc; > + struct iio_dev *indio_dev; > + int ret; > + > + indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*saradc)); > + if (!indio_dev) > + return -ENOMEM; > + > + saradc = iio_priv(indio_dev); > + indio_dev->name = "sophgo-cv1800b-adc"; > + indio_dev->modes = INDIO_DIRECT_MODE; > + indio_dev->info = &cv1800b_adc_info; > + indio_dev->num_channels = ARRAY_SIZE(sophgo_channels); > + indio_dev->channels = sophgo_channels; > + > + saradc->clk = devm_clk_get_enabled(&pdev->dev, NULL); > + if (IS_ERR(saradc->clk)) > + return PTR_ERR(saradc->clk); > + > + saradc->regs = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(saradc->regs)) > + return PTR_ERR(saradc->regs); > + > + saradc->irq = platform_get_irq_optional(pdev, 0); > + if (saradc->irq >= 0) { > + init_completion(&saradc->completion); > + ret = devm_request_irq(&pdev->dev, saradc->irq, > + cv1800b_adc_interrupt_handler, 0, > + dev_name(&pdev->dev), saradc); > + if (ret) > + return ret; > + > + writel(1, saradc->regs + CV1800B_ADC_INTR_EN_REG); > + } > + > + ret = devm_mutex_init(&pdev->dev, &saradc->lock); > + if (ret) > + return ret; Blank line here slightly helps readability as two unrelated blocks of code. > + writel(FIELD_PREP(CV1800B_MASK_STARTUP_CYCLE, 15) | > + FIELD_PREP(CV1800B_MASK_SAMPLE_WINDOW, 15) | > + FIELD_PREP(CV1800B_MASK_CLKDIV, 1) | > + FIELD_PREP(CV1800B_MASK_COMPARE_CYCLE, 15), > + saradc->regs + CV1800B_ADC_CYC_SET_REG); > + > + return devm_iio_device_register(&pdev->dev, indio_dev); > +}