Christophe JAILLET wrote:
> Le 08/08/2024 à 21:28, Dan Carpenter a écrit :
> > This error path was intended to return, and not just print an error. The
> > current code will lead to an error pointer dereference.
> >
> > Fixes: 371f778b83cd ("iio: adc: add support for pac1921")
> > Signed-off-by: Dan Carpenter <dan.carpenter-QSEj5FYQhm4dnm+yROfE0A@xxxxxxxxxxxxxxxx>
> > ---
> > drivers/iio/adc/pac1921.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/adc/pac1921.c b/drivers/iio/adc/pac1921.c
> > index d04c6685d780..8200a47bdf21 100644
> > --- a/drivers/iio/adc/pac1921.c
> > +++ b/drivers/iio/adc/pac1921.c
> > @@ -1168,8 +1168,8 @@ static int pac1921_probe(struct i2c_client *client)
> >
> > priv->regmap = devm_regmap_init_i2c(client, &pac1921_regmap_config);
> > if (IS_ERR(priv->regmap))
> > - dev_err_probe(dev, (int)PTR_ERR(priv->regmap),
> > - "Cannot initialize register map\n");
> > + return dev_err_probe(dev, (int)PTR_ERR(priv->regmap),
>
> The (int) is unusual.
>
The (int) explicit cast is to address Wconversion warnings since dev_err_probe
takes an int as argument.
>
> CJ
>
> > + "Cannot initialize register map\n");
> >
> > devm_mutex_init(dev, &priv->lock);
> >
>
Thanks,
Matteo Martelli
