On 24/07/2024 18:14, Krzysztof Kozlowski wrote: > On 24/07/2024 17:54, Ramona Alexandra Nechita wrote: >> Add support for AD7770, AD7771, AD7779 ADCs. The device is capable of >> sending out data both on DOUT lines interface,as on the SDO line. >> The driver currently implements only theSDO data streaming mode. SPI >> communication is used alternatively foraccessingregisters and streaming > > Typo, please run spell check. > > Please use subject prefixes matching the subsystem. You can get them for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching. For bindings, the preferred subjects are > explained here: > https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > > There is no "drivers". > >> data. Register access are protected by crc8. >> >> Signed-off-by: Ramona Alexandra Nechita <ramona.nechita@xxxxxxxxxx> >> --- >> drivers/iio/adc/Kconfig | 11 + >> drivers/iio/adc/Makefile | 1 + >> drivers/iio/adc/ad7779.c | 952 +++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 964 insertions(+) >> create mode 100644 drivers/iio/adc/ad7779.c >> > > The driver has several trivial style issues. Please be sure such > trivialities are fixed. Get internal review on this. You do need to ask > community to tell you that you must run checkpatch. Or to tell them that > indentation/alignment is entirely broken. Grab some colleague of yours > and perform internal review first. This applies to entire Analog, > because there is increased amount of contributions from Analog and not > all of them look like passing basic sanity checks. > > By sending code full of silly trivialities, community reviewers might > feel overwhelmed and quite grumpy. The amount of trivial warnings pointed out by compilation in separate email is as well disappointing. You do not need community to check if all variables are used - compilers tell it, so use them. Toolchains and static checkers will point some issues without any need of using community reviewers. Look, isn't it great? Instead of using human force you can use tools... This applies to all Analog contributions - *you must check* your code with W=1, sparse, smatch and coccinelle. Best regards, Krzysztof
