Re: [PATCH v7 9/9] iio: adc: ad7173: Add support for AD411x devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 15/07/2024 19:17, Ceclan, Dumitru wrote:
>>
>> Please run scripts/checkpatch.pl and fix reported warnings. Then please
>> run `scripts/checkpatch.pl --strict` and (probably) fix more warnings.
>> Some warnings can be ignored, especially from --strict run, but the code
>> here looks like it needs a fix. Feel free to get in touch if the warning
>> is not clear.
>>
>> Best regards,
>> Krzysztof
>>
> 
> I do not get any warnings, only checks
> 
> If you meant the checks:
> - for the alignment check, i would only argue for struct_group(config_props that looks good
> - for unnecessary parentheses the compiler warning appears without the parentheses:
>       warning: suggest parentheses around comparison in operand of ‘!=’ [-Wparentheses]

Hm, in that case it looks like you documented some entirely different
bindings?

Best regards,
Krzysztof





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux