On Fri, 12 Jul 2024 20:54:00 +0530 Kaustabh Chakraborty <kauschluss@xxxxxxxxxxx> wrote: > In order to allow newer devices which are compatible with existing > sensors, issuing a warning for an unknown chipid indicates that > something has gone wrong with the init process, which isn't ideal. > Swap it with a friendlier info message to get things right. > > Suggested-by: Conor Dooley <conor@xxxxxxxxxx> > Signed-off-by: Kaustabh Chakraborty <kauschluss@xxxxxxxxxxx> Give the patch series a cover letter next time as it makes it easy for people to comment on whole series together + gives the series a nice name in patchwork etc. Plus this isn't (I think) version 1. So that should be in the patch naming. Actual change looks fine to me. Thanks, Jonathan > --- > drivers/iio/light/stk3310.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c > index e3470d6743ef..48a971de6a04 100644 > --- a/drivers/iio/light/stk3310.c > +++ b/drivers/iio/light/stk3310.c > @@ -496,7 +496,7 @@ static int stk3310_init(struct iio_dev *indio_dev) > > ret = stk3310_check_chip_id(chipid); > if (ret < 0) > - dev_warn(&client->dev, "unknown chip id: 0x%x\n", chipid); > + dev_info(&client->dev, "new unknown chip id: 0x%x\n", chipid); > > state = STK3310_STATE_EN_ALS | STK3310_STATE_EN_PS; > ret = stk3310_set_state(data, state);
