On 7/11/24 6:42 AM, Kim Seer Paller wrote: > Introduce a generalized DAC binding that can be used by DACs that have > similar properties adding output-range-microamp and output-range-microvolt. > > Signed-off-by: Kim Seer Paller <kimseer.paller@xxxxxxxxxx> > --- > .../devicetree/bindings/iio/dac/dac.yaml | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/dac/dac.yaml > > diff --git a/Documentation/devicetree/bindings/iio/dac/dac.yaml b/Documentation/devicetree/bindings/iio/dac/dac.yaml > new file mode 100644 > index 000000000000..a9787bbcd22b > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/dac/dac.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/dac/dac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: IIO Common Properties for DAC Channels > + > +maintainers: > + - Jonathan Cameron <jic23@xxxxxxxxxx> > + > +description: > + A few properties are defined in a common way for DAC channels. > + > +properties: > + $nodename: > + pattern: "^channel(@[0-9a-f]+)?$" > + description: > + A channel index should match reg. > + > + reg: > + maxItems: 1 > + > + label: > + description: Unique name to identify which channel this is. > + > + output-range-microamp: > + maxItems: 2 > + minItems: 2 > + description: > + Specify the channel output full scale range in microamperes. > + > + output-range-microvolt: > + maxItems: 2 > + minItems: 2 > + description: > + Specify the channel output full scale range in microvolts. > + > +oneOf: > + - required: > + - reg > + - output-range-microamp > + - required: > + - reg > + - output-range-microvolt > + > +required: > + - reg > + It looks like oneOf: and required: are missing an indent, which is likely the cause of the Rob-bot complaints. Also, shouldn't the last required: be an item in the oneOf: list? > +additionalProperties: true
