On 04/07/2024 10:18, Petar Stoykov wrote: > On Tue, Jul 2, 2024 at 5:15 PM Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> >> On 02/07/2024 16:59, Petar Stoykov via B4 Relay wrote: >>> From: Petar Stoykov <pd.pstoykov@xxxxxxxxx> >>> >>> Sensirion SDP500 is a digital differential pressure sensor. It provides >>> a digital I2C output. Add devicetree bindings requiring the compatible >>> string and I2C slave address (reg). >>> >> >> You did not test your code before sending. > > I tested the driver for sdp500 on our system and it worked well. > I must admit that I forgot to change the dts to sdp510 and retest. > >> >> Please respond to existing feedback from v1 and v2, thus confirm that >> you understood it and you are or are not going to implement it. >> > > I tried to reply to all previous comments. Sorry if I missed something. > >> It does not look like you tested the bindings, at least after quick >> look. Please run `make dt_binding_check` (see >> Documentation/devicetree/bindings/writing-schema.rst for instructions). >> Maybe you need to update your dtschema and yamllint. > > I didn't know about that dt_binding_check. Then I spent a few hours > yesterday fighting with dependencies to get it running. It's just one command: pipx install dtschema yamllint (or pip, depending on your system) Best regards, Krzysztof
