On Tue, Jul 2, 2024 at 7:03 PM Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@xxxxxxxxxx> wrote: > > From: Nuno Sa <nuno.sa@xxxxxxxxxx> > > Use iio_for_each_active_channel() to iterate over active channels > accessing '.masklength' so it can be annotated as __private when there are > no more direct users of it. > Reviewed-by: Alexandru Ardelean <aardelean@xxxxxxxxxxxx> > Signed-off-by: Nuno Sa <nuno.sa@xxxxxxxxxx> > --- > drivers/iio/adc/at91_adc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c > index eb501e3c86a5..af4b0224076f 100644 > --- a/drivers/iio/adc/at91_adc.c > +++ b/drivers/iio/adc/at91_adc.c > @@ -268,9 +268,7 @@ static irqreturn_t at91_adc_trigger_handler(int irq, void *p) > struct iio_chan_spec const *chan; > int i, j = 0; > > - for (i = 0; i < idev->masklength; i++) { > - if (!test_bit(i, idev->active_scan_mask)) > - continue; > + iio_for_each_active_channel(idev, i) { > chan = idev->channels + i; > st->buffer[j] = at91_adc_readl(st, AT91_ADC_CHAN(st, chan->channel)); > j++; > > -- > 2.45.2 > > >