On Sun, 23 Jun 2024 17:03:19 +0100 Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > On Tue, 18 Jun 2024 15:32:04 +0200 > Nuno Sa <nuno.sa@xxxxxxxxxx> wrote: > > > Split trigger handling for devices that have paging and need to > > select the correct page to get the data. Although this actually > > introduces more LOC, it makes the code and the locking clear. It will > > also make the following move to the cleanup magic cleaner. > > > > Signed-off-by: Nuno Sa <nuno.sa@xxxxxxxxxx> > Hi Nuno, > > Just one thing, > > > + ret = spi_sync(adis->spi, &adis->msg); > > + if (ret) > > dev_err(&adis->spi->dev, "Failed to read data: %d", ret); > > - goto irq_done; > > - } > > + else > > + iio_push_to_buffers_with_timestamp(indio_dev, adis->buffer, > > + pf->timestamp); > > Keep the goto as having an indented 'good' path is not great for readability. > Meh. That was (almost) all I found to comment on so I changed it back whilst applying. Applied to the togreg branch of iio.git and pushed out as testing. Thanks, Jonathan > > > > - iio_push_to_buffers_with_timestamp(indio_dev, adis->buffer, > > - pf->timestamp); > > - > > -irq_done: > > iio_trigger_notify_done(indio_dev->trig); > > > > return IRQ_HANDLED; > > > >
