Re: [PATCH v3 02/41] iio: accel: kxsd9: Make use of regmap_clear_bits()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 17 Jun 2024 09:49:42 -0400
Trevor Gamblin <tgamblin@xxxxxxxxxxxx> wrote:

> Instead of using regmap_update_bits() and passing val = 0, use
> regmap_clear_bits().
> 
> Suggested-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx>
> Signed-off-by: Trevor Gamblin <tgamblin@xxxxxxxxxxxx>
> ---
>  drivers/iio/accel/kxsd9.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/accel/kxsd9.c b/drivers/iio/accel/kxsd9.c
> index ba99649fe195..03ce032e06ff 100644
> --- a/drivers/iio/accel/kxsd9.c
> +++ b/drivers/iio/accel/kxsd9.c
> @@ -370,10 +370,8 @@ static int kxsd9_power_down(struct kxsd9_state *st)
>  	 * make sure we conserve power even if there are others users on the
>  	 * regulators.
>  	 */
> -	ret = regmap_update_bits(st->map,
> -				 KXSD9_REG_CTRL_B,
> -				 KXSD9_CTRL_B_ENABLE,
> -				 0);
> +	ret = regmap_clear_bits(st->map, KXSD9_REG_CTRL_B,
> +				KXSD9_CTRL_B_ENABLE);
Now fits neatly on one line at precisely 80 chars.
I rewrapped whilst applying.

Jonathan

>  	if (ret)
>  		return ret;
>  
> 






[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux