On Mon, 17 Jun 2024 13:30:01 -0600 "Rob Herring (Arm)" <robh@xxxxxxxxxx> wrote: > On Mon, 17 Jun 2024 20:32:14 +0200, Francesco Dolcini wrote: > > From: João Paulo Gonçalves <joao.goncalves@xxxxxxxxxxx> > > > > Add devicetree bindings for Texas Instruments ADS1119 16-bit ADC > > with I2C interface. > > > > Datasheet: https://www.ti.com/lit/gpn/ads1119 > > Signed-off-by: João Paulo Gonçalves <joao.goncalves@xxxxxxxxxxx> > > Signed-off-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx> > > Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > --- > > v3: > > - add avdd and dvdd supplies > > - add Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx > > > > v2: > > - add diff-channels and single-channel > > - add XOR check to make diff/single channel property required > > - add interrupts, reset-gpios and vref-supply to the example > > - fix missing additionalProperties/unevaluatedProperties warning in channels > > - remove ti,gain and ti,datarate as they aren't fixed hw properties > > - remove unnecessary | > > --- > > .../bindings/iio/adc/ti,ads1119.yaml | 155 ++++++++++++++++++ > > MAINTAINERS | 7 + > > 2 files changed, 162 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads1119.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/ti,ads1119.yaml: single-channel: missing type definition > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240617183215.4080-2-francesco@xxxxxxxxxx > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. Just for the record (and so I remember when I get to reviewing the driver patch). This should note dependency on dd471a2b7759 ("dt-bindings: iio: adc: Add single-channel property") but seeing as that is only char-misc.git/char-misc-next I suspect that won't help the bot much! > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >
