On Wed, 12 Jun 2024 16:03:05 -0500 David Lechner <dlechner@xxxxxxxxxxxx> wrote: > This makes use of the new devm_regulator_get_enable_read_voltage() > function to reduce boilerplate code. > > Error messages have changed slightly since there are now fewer places > where we print an error. The rest of the logic of selecting which > supply to use as the reference voltage remains the same. > > Also 1000 is replaced by MILLI in a few places for consistency. > > Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx> Complicated bit of code, but seems correct. However, it crossed with Alisa-Dariana switching adding a struct device *dev = &spi->dev to probe() that I picked up earlier today. I could unwind that but given Alisa-Dariana has a number of other patches on this driver in flight, I'd like the two of you to work out the best resolution between you. Maybe easiest option is that Alisa-Dariana sends this a first patch of the next series I should pick up. Thanks, Jonathan
