Looks good. One minor neat being the last change won't be needed after patch 2 is updated. Also, I think it will help visualize the patch series if a cover letter is added. If running format-patch, the --cover-letter should help with it. e.g. git format-patch -v3 --thread=shallow --cover-letter --to="..." --cc="..." -3 On 06/03, Fernando Yang wrote: > Fix some codestyle errors indicated by checkpatch.pl > > Signed-off-by: Fernando Yang <hagisf@xxxxxx> > --- > drivers/iio/adc/ad7266.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/ad7266.c b/drivers/iio/adc/ad7266.c > index 356c2fe07..5a2f1bb27 100644 > --- a/drivers/iio/adc/ad7266.c > +++ b/drivers/iio/adc/ad7266.c > @@ -63,12 +63,14 @@ static int ad7266_powerdown(struct ad7266_state *st) > static int ad7266_preenable(struct iio_dev *indio_dev) > { > struct ad7266_state *st = iio_priv(indio_dev); > + > return ad7266_wakeup(st); > } > > static int ad7266_postdisable(struct iio_dev *indio_dev) > { > struct ad7266_state *st = iio_priv(indio_dev); > + > return ad7266_powerdown(st); > } > > @@ -153,7 +155,7 @@ static int ad7266_read_raw(struct iio_dev *indio_dev, > case IIO_CHAN_INFO_RAW: > iio_device_claim_direct_scoped(return -EBUSY, indio_dev) { > ret = ad7266_read_single(st, val, chan->address); This is not needed as comment on patch 2. > - > + > if (ret < 0) > return ret; > *val = (*val >> 2) & 0xfff; > -- > 2.34.1 > >