From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> Sent: 04 June 2024 10:45 To: Arthur Becker; Jonathan Cameron; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley; Javier Carrasco Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx Subject: [EXTERNAL]Re: [PATCH v4 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings > On 04/06/2024 10:01, Arthur Becker via B4 Relay wrote: > > From: Arthur Becker <arthur.becker@xxxxxxxxxx> > > > > Device tree bindings for the vishay VEML6040 RGBW light sensor iio > > driver > > > > Signed-off-by: Arthur Becker <arthur.becker@xxxxxxxxxx> > > --- > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > If there is any resend: > A nit, subject: drop second/last, redundant "bindings". The > "dt-bindings" prefix is already stating that these are bindings. > See also: > https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > > Best regards, > Krzysztof Oups! I had read that part of the documentation but forgot about it... I'll think about it next time. Thanks for the review! Kind Regards Arthur