On Wed, May 29, 2024 at 09:12:28PM +0100, Jonathan Cameron wrote: > On Mon, 13 May 2024 01:05:24 +0200 > Vasileios Amoiridis <vassilisamir@xxxxxxxxx> wrote: > > > BMP2xx, BME280, BMP3xx, and BMP5xx use continuous buffers for their > > temperature, pressure and humidity readings. This facilitates the > > use of burst/bulk reads in order to acquire data faster. The > > approach is different from the one used in oneshot captures. > > > > BMP085 & BMP1xx devices use a completely different measurement > > process that is well defined and is used in their buffer_handler(). > > > > Suggested-by: Angel Iglesias <ang.iglesiasg@xxxxxxxxx> > > Signed-off-by: Vasileios Amoiridis <vassilisamir@xxxxxxxxx> > > --- > > > + > > +const struct iio_buffer_setup_ops bmp280_buffer_setup_ops = { > 0-day noted that this isn't actually used. > I'll add it to the buffer setup where it's currently passed as null. Hi Jonathan, Yes, 0-day informed me, but I was not sure what to do so I was waiting to see if you would see it during the weekend. Thanks for taking care of it. Cheers, Vasilis > > + .preenable = bmp280_buffer_preenable, > > + .postdisable = bmp280_buffer_postdisable, > > +}; > > +