On Wed, May 29, 2024 at 04:01:24PM +0000, Dr. David Alan Gilbert wrote:
> * Dan Carpenter (dan.carpenter@xxxxxxxxxx) wrote:
> > On Wed, May 29, 2024 at 12:30:08AM +0100, linux@xxxxxxxxxxx wrote:
> > > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> > >
> > > 'adt7316_limit_regs' has never been used since the original
> > > commit 35f6b6b86ede ("staging: iio: new ADT7316/7/8 and ADT7516/7/9
> > > driver").
> > >
> > > The comment above it is a copy-and-paste from a different struct.
> > >
> > > Remove both the struct and the comment.
> > >
> > > Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
> > > ---
> > > drivers/staging/iio/addac/adt7316.c | 8 --------
> > > 1 file changed, 8 deletions(-)
> > >
> > > diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> > > index 79467f056a05..23d036d2802c 100644
> > > --- a/drivers/staging/iio/addac/adt7316.c
> > > +++ b/drivers/staging/iio/addac/adt7316.c
> > > @@ -209,14 +209,6 @@ struct adt7316_chip_info {
> > > #define ADT7316_TEMP_AIN_INT_MASK \
> > > (ADT7316_TEMP_INT_MASK)
> > >
> > > -/*
> > > - * struct adt7316_chip_info - chip specific information
> > > - */
> > > -
> > > -struct adt7316_limit_regs {
> > > - u16 data_high;
> > > - u16 data_low;
> > > -};
> > >
> >
> > Could you delete the blank line as well? Otherwise we have two blank
> > lines in a row and checkpatch will complain.
>
> Sure, v2 sent.
> (checkpatch didn't moan at me with or without).
Thanks. You'd need to apply the patch and re-run checkpatch.pl with the
-f option. It's not something that's obvious.
regards,
dan carpenter
