On 28/05/2024 18:02, Chen-Yu Tsai wrote: > On Thu, Apr 18, 2024 at 1:04 AM Chris Morgan <macroalpha82@xxxxxxxxx> wrote: >> >> From: Chris Morgan <macromorgan@xxxxxxxxxxx> >> >> Add the GPADC required clock and reset which is used for the onboard >> GPADC. >> >> Signed-off-by: Chris Morgan <macromorgan@xxxxxxxxxxx> >> --- >> drivers/clk/sunxi-ng/ccu-sun50i-h616.c | 5 +++++ >> drivers/clk/sunxi-ng/ccu-sun50i-h616.h | 2 +- > > >> include/dt-bindings/clock/sun50i-h616-ccu.h | 1 + >> include/dt-bindings/reset/sun50i-h616-ccu.h | 1 + > > These need an Ack from the DT binding maintainers. And it's better to > split these into a separate patch. I am surprised that they were combined... So usual comment: Please split the bindings, because we do not want bindings to be in the same commit as driver. Best regards, Krzysztof
