Re: [PATCH v4 08/10] iio: imu: adis16475: Re-define ADIS16475_DATA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 24 May 2024 12:47:38 +0200
Nuno Sá <noname.nuno@xxxxxxxxx> wrote:

> On Fri, 2024-05-24 at 12:00 +0300, Ramona Gradinariu wrote:
> > Re-define ADIS16475_DATA such that it takes _has_fifo as parameter.
> > 
> > Signed-off-by: Ramona Gradinariu <ramona.bolboaca13@xxxxxxxxx>
> > ---  
> 
> I may be missing something but do we actually need to patches redefining the macro?
> If I'm not missing nothing the first patch is only relevant for the new ADIS devices
> which are added in patch 10. So maybe squash both patches changing the macro.
> 
> - Nuno Sá
> 
If that's not possible for some reason, give them both slightly more detailed
patch titles. It's confusing to have them identical!
 
I'd prefer them squashed as Nuno suggested.





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux