On Wed, May 22, 2024 at 03:01:52PM +0000, Nechita, Ramona wrote: > Hello Nuno, > > I apologize, I accidentally submitted the updated version that I used for the > project, instead of the one without axi. I will fix it and resend the patch > asap. First of all, do not top-post! Second, don't do ASAP, take your time, read the comments given for this version and address the same / similar issues in any code you are possessing before sending. > -----Original Message----- > From: Nuno Sá <noname.nuno@xxxxxxxxx> > Sent: Wednesday, May 22, 2024 5:36 PM > On Wed, 2024-05-22 at 14:59 +0300, ranechita wrote: > > Added support for ad7770,ad7771,ad7779 ADCs. The data is streamed only > > on the spi-mode, without using the data lines. > Is this even compiling? This is definitely not code to be upstreamed since it > relies on the our out-of-tree/legacy driver for the adi-axi-adc. You need to > convert this to use the IIO backend framework (adding new interfaces if > needed). -- With Best Regards, Andy Shevchenko